diff --git a/tests/Feature/Billing/AddonEntitlementTest.php b/tests/Feature/Billing/AddonEntitlementTest.php
index a970f59..2b82461 100644
--- a/tests/Feature/Billing/AddonEntitlementTest.php
+++ b/tests/Feature/Billing/AddonEntitlementTest.php
@@ -51,6 +51,10 @@ function entitlementShopper(string $plan = 'team'): array
$order->subscription->update(['instance_id' => $instance->id]);
+ // The tests that buy through the shop call Billing::purchase(), which
+ // since Task 5 refuses outright without a Stripe key for the active mode.
+ withStripeSecret();
+
return [$customer, $user, $order->subscription->fresh()];
}
diff --git a/tests/Feature/Billing/CustomDomainAccessTest.php b/tests/Feature/Billing/CustomDomainAccessTest.php
index c63bacc..af14c35 100644
--- a/tests/Feature/Billing/CustomDomainAccessTest.php
+++ b/tests/Feature/Billing/CustomDomainAccessTest.php
@@ -46,6 +46,12 @@ function domainCustomer(string $plan, array $instanceAttributes = []): array
'instance_id' => $instance->id,
]);
+ // One test below calls Billing::purchase(), which since Task 5 refuses
+ // outright without a Stripe key for the active mode. Without this, that
+ // test would see the same "no order" result for the wrong reason — the
+ // Stripe guard, not the plan-restriction it names — and prove nothing.
+ withStripeSecret();
+
return [$customer, $user, $instance, $subscription];
}
diff --git a/tests/Feature/Billing/PaidOrderFulfilmentTest.php b/tests/Feature/Billing/PaidOrderFulfilmentTest.php
index bdf4d48..b60a1ea 100644
--- a/tests/Feature/Billing/PaidOrderFulfilmentTest.php
+++ b/tests/Feature/Billing/PaidOrderFulfilmentTest.php
@@ -33,6 +33,13 @@ use Livewire\Livewire;
beforeEach(function () {
$this->stripe = new FakeStripeClient;
app()->instance(StripeClient::class, $this->stripe);
+
+ // Every test here calls Billing::purchase() to place the order it then
+ // marks paid by hand. Since Task 5, that call refuses outright without a
+ // Stripe key for the active mode — binding the fake StripeClient above
+ // does not help, because the guard reads the vault directly rather than
+ // going through the StripeClient interface.
+ withStripeSecret();
});
/** A customer on a live contract, with a machine. */
diff --git a/tests/Feature/Billing/PendingPlanChangeTest.php b/tests/Feature/Billing/PendingPlanChangeTest.php
index be5c640..49369ad 100644
--- a/tests/Feature/Billing/PendingPlanChangeTest.php
+++ b/tests/Feature/Billing/PendingPlanChangeTest.php
@@ -45,6 +45,11 @@ function pendingChangeCustomer(string $plan = 'business'): array
// due date arrives against this id, so there has to be one.
$subscription->update(['instance_id' => $instance->id, 'stripe_subscription_id' => 'sub_'.$customer->id]);
+ // These tests call Billing::purchase() to book the downgrade/upgrade,
+ // which since Task 5 refuses outright without a Stripe key for the
+ // active mode.
+ withStripeSecret();
+
return [$customer, $user, $subscription->fresh(), $instance];
}
diff --git a/tests/Feature/Billing/StorageAllowanceTest.php b/tests/Feature/Billing/StorageAllowanceTest.php
index 8cbaa3e..82e3ec7 100644
--- a/tests/Feature/Billing/StorageAllowanceTest.php
+++ b/tests/Feature/Billing/StorageAllowanceTest.php
@@ -65,6 +65,11 @@ function storageFixture(string $plan = 'team', array $instanceAttributes = []):
$subscription->update(['instance_id' => $instance->id]);
+ // Some of these tests book storage packs through Billing::purchase(),
+ // which since Task 5 refuses outright without a Stripe key for the
+ // active mode.
+ withStripeSecret();
+
return [
'host' => $host,
'order' => $order,
diff --git a/tests/Feature/BillingTest.php b/tests/Feature/BillingTest.php
index c1eb0d0..0b7340a 100644
--- a/tests/Feature/BillingTest.php
+++ b/tests/Feature/BillingTest.php
@@ -14,6 +14,10 @@ function billingSetup(string $plan = 'start'): array
$order = Order::factory()->create(['customer_id' => $customer->id, 'plan' => $plan]);
Instance::factory()->create(['customer_id' => $customer->id, 'order_id' => $order->id, 'plan' => $plan, 'status' => 'active']);
+ // Several of these tests call Billing::purchase(), which since Task 5
+ // refuses outright without a Stripe key for the active mode.
+ withStripeSecret();
+
return compact('user', 'customer');
}
diff --git a/tests/Feature/CartTest.php b/tests/Feature/CartTest.php
index ae83d52..32f9479 100644
--- a/tests/Feature/CartTest.php
+++ b/tests/Feature/CartTest.php
@@ -3,14 +3,21 @@
use App\Livewire\Billing;
use App\Livewire\ConfirmRemoveOrder;
use App\Models\Customer;
+use App\Models\Instance;
use App\Models\Order;
use App\Models\User;
+use Illuminate\Support\Carbon;
+use Illuminate\Support\Number;
function cartCustomer(): array
{
$customer = Customer::factory()->create();
$user = User::factory()->create(['email' => $customer->email]);
+ // Some of these tests call Billing::purchase(), which since Task 5
+ // refuses outright without a Stripe key for the active mode.
+ withStripeSecret();
+
return [$customer, $user];
}
@@ -73,7 +80,7 @@ it('refuses to remove an order that is already paid', function () {
it('keeps at most one plan change in the cart', function () {
[$customer, $user] = cartCustomer();
- App\Models\Instance::factory()->for($customer)->create(['plan' => 'start', 'status' => 'active']);
+ Instance::factory()->for($customer)->create(['plan' => 'start', 'status' => 'active']);
$component = Livewire\Livewire::actingAs($user)->test(Billing::class);
$component->call('purchase', 'upgrade', 'business');
@@ -88,7 +95,7 @@ it('keeps at most one plan change in the cart', function () {
it('still lets add-ons stack', function () {
[$customer, $user] = cartCustomer();
- App\Models\Instance::factory()->for($customer)->create(['plan' => 'team', 'status' => 'active']);
+ Instance::factory()->for($customer)->create(['plan' => 'team', 'status' => 'active']);
$component = Livewire\Livewire::actingAs($user)->test(Billing::class);
$component->call('purchase', 'storage');
@@ -127,7 +134,7 @@ it('separates what recurs from a one-off top-up', function () {
// Formatted through the same helper the view uses, or the non-breaking
// space in the currency makes this a test about whitespace.
$expected = __('billing.cart.recurring_note', [
- 'amount' => Illuminate\Support\Number::currency(12.00, in: 'EUR', locale: 'de'),
+ 'amount' => Number::currency(12.00, in: 'EUR', locale: 'de'),
]);
Livewire\Livewire::actingAs($user)->test(Billing::class)->assertSee($expected);
@@ -143,7 +150,7 @@ it('keeps the recurring figure consistent with the total to the cent', function
Order::factory()->for($customer)->create(['type' => 'storage', 'amount_cents' => 3, 'status' => 'pending']);
Order::factory()->for($customer)->create(['type' => 'storage', 'amount_cents' => 3, 'status' => 'pending']);
- $expected = Illuminate\Support\Number::currency(0.08, in: 'EUR', locale: 'de');
+ $expected = Number::currency(0.08, in: 'EUR', locale: 'de');
Livewire\Livewire::actingAs($user)->test(Billing::class)
->assertSee($expected) // total gross
@@ -188,7 +195,7 @@ it('accepts a verified value stored in display form', function () {
config()->set('provisioning.tax.rate_percent', 20);
config()->set('provisioning.tax.seller_country', 'AT');
- [$customer, ] = cartCustomer();
+ [$customer] = cartCustomer();
Order::factory()->for($customer)->create(['type' => 'storage', 'amount_cents' => 1000, 'status' => 'pending']);
// A verifier may hand back the number the way it prints it; spaces are
@@ -200,7 +207,7 @@ it('accepts a verified value stored in display form', function () {
]);
expect($customer->fresh()->hasVerifiedVatId())->toBeTrue()
- ->and($customer->fresh()->vat_id_verified_at)->toBeInstanceOf(Illuminate\Support\Carbon::class)
+ ->and($customer->fresh()->vat_id_verified_at)->toBeInstanceOf(Carbon::class)
->and(Order::query()->first()->fresh()->grossCents())->toBe(1000);
});
@@ -208,7 +215,7 @@ it('will not let a typed-in VAT ID zero the tax', function () {
config()->set('provisioning.tax.rate_percent', 20);
config()->set('provisioning.tax.seller_country', 'AT');
- [$customer, ] = cartCustomer();
+ [$customer] = cartCustomer();
Order::factory()->for($customer)->create(['type' => 'storage', 'amount_cents' => 1000, 'status' => 'pending']);
// Plausible-looking but unverified: still domestic VAT.
diff --git a/tests/Feature/CheckoutWithoutStripeKeyTest.php b/tests/Feature/CheckoutWithoutStripeKeyTest.php
new file mode 100644
index 0000000..ea49efe
--- /dev/null
+++ b/tests/Feature/CheckoutWithoutStripeKeyTest.php
@@ -0,0 +1,62 @@
+ app(HttpStripeClient::class)->createPrice('prod_x', 100, 'EUR', 'month'))
+ ->toThrow(StripeNotConfigured::class);
+});
+
+it('does not create an order when the key is missing', function () {
+ OperatingMode::set(OperatingMode::Test);
+ $customer = Customer::factory()->create();
+ // A portal user is matched to its customer by email, not by a foreign
+ // key — see the existing Billing feature tests (e.g. StorageAllowanceTest).
+ $user = User::factory()->create(['email' => $customer->email]);
+
+ // 'team' is a real, sellable plan (seeded by the plan-catalogue migration)
+ // that ranks above the customer's implicit 'start' plan — a genuine
+ // upgrade the purchase() guards would otherwise accept. A made-up key
+ // would be refused by the existing plan-validity check regardless of
+ // whether the Stripe guard works at all, and would prove nothing.
+ //
+ // assertHasErrors(), not assertHasNoErrors(): the guard reports through
+ // addError('purchase', …) — the same page-blocking pattern order.blade.php
+ // already uses for "cannot proceed" — and Livewire's test harness folds
+ // any non-empty error bag into the call's result. Asserting no errors
+ // here would contradict the very behaviour this test exists to prove.
+ Livewire::actingAs($user)
+ ->test(Billing::class)
+ ->call('purchase', 'upgrade', 'team')
+ ->assertHasErrors('purchase');
+
+ // Der Punkt: nach der Zahlung wäre es zu spät. Es darf gar nichts entstehen.
+ expect(Order::count())->toBe(0);
+});
+
+it('says why instead of failing silently', function () {
+ OperatingMode::set(OperatingMode::Test);
+ $customer = Customer::factory()->create();
+ $user = User::factory()->create(['email' => $customer->email]);
+
+ Livewire::actingAs($user)
+ ->test(Billing::class)
+ ->call('purchase', 'upgrade', 'team')
+ ->assertSee(__('billing.stripe_not_configured'));
+});
diff --git a/tests/Feature/DowngradeTest.php b/tests/Feature/DowngradeTest.php
index d8700c4..33627ac 100644
--- a/tests/Feature/DowngradeTest.php
+++ b/tests/Feature/DowngradeTest.php
@@ -19,7 +19,6 @@ use Livewire\Livewire;
* disabled button that does not name the obstacle is the thing people ring
* about.
*/
-
function downgradeCustomer(int $seats = 1, ?int $usedBytes = null): array
{
$user = User::factory()->create();
@@ -44,6 +43,12 @@ function downgradeCustomer(int $seats = 1, ?int $usedBytes = null): array
]);
}
+ // One test below calls Billing::purchase(), which since Task 5 refuses
+ // outright without a Stripe key for the active mode. Without this, that
+ // test would see the same "no order" result for the wrong reason — the
+ // Stripe guard, not the seat block it names — and prove nothing.
+ withStripeSecret();
+
return [$user, $customer, $instance];
}
diff --git a/tests/Pest.php b/tests/Pest.php
index 7db9704..26b48b7 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -11,6 +11,7 @@ use App\Services\Monitoring\FakeMonitoringClient;
use App\Services\Monitoring\MonitoringClient;
use App\Services\Proxmox\FakeProxmoxClient;
use App\Services\Proxmox\ProxmoxClient;
+use App\Services\Secrets\SecretVault;
use App\Services\Ssh\FakeRemoteShell;
use App\Services\Ssh\RemoteShell;
use App\Services\Traefik\FakeTraefikWriter;
@@ -117,6 +118,22 @@ function admin(): Operator
return Operator::factory()->role('Owner')->create(['password' => 'password']);
}
+/**
+ * Deposits a Stripe key for whichever operating mode is current, so
+ * Billing::purchase() — refusing outright without one since Task 5 — actually
+ * reaches the code a test is about instead of stopping before anything is
+ * touched.
+ *
+ * Deliberately NOT a global beforeEach(): CheckoutWithoutStripeKeyTest and
+ * StripeStrictModeTest are precisely about the absence of this key, and a
+ * suite-wide fixture would quietly defeat them. Call this only from a test's
+ * own fixture/beforeEach where a purchase is expected to go through.
+ */
+function withStripeSecret(): void
+{
+ app(SecretVault::class)->put('stripe.secret', 'sk_test_fixture', Operator::factory()->create());
+}
+
/**
* Undo the mailbox-seeding migration's baseline, for tests written before it.
*