ab4b0311d4
tests / pest (push) Failing after 11m24s
Details
tests / assets (push) Successful in 21s
Details
tests / release (push) Has been skipped
Details
The application knows nothing about NFS and should not. It writes to a directory; whether that is a local disk, a bind mount or a NAS over NFS 4.1 belongs to the mount. No protocol library, the target changes without code changing with it, and the whole thing is testable against a temp directory. The finding that shaped it: mkdir -p on a path whose mount is NOT there succeeds. It creates the empty directory beneath the mountpoint, writes the invoice onto the container's own disk and reports success — so an unmounted NAS would quietly collect invoices locally while every check said it worked. An archive that silently is not the archive is worse than none. The root is therefore never created, only used: a missing root means a missing mount, and that is a failure. Only the year subdirectory is created, inside a root already proven to exist. Written to a .part and renamed. A rename within one filesystem is atomic, so whatever watches that folder never sees a truncated PDF and takes it for a finished invoice. The size is read back afterwards rather than the write being trusted: over a network mount a short write can report success, and an archive of truncated files looks exactly like one that worked. Queued, not done during the request. A network mount can block for its whole timeout, and an invoice must not fail to be issued because a NAS is rebooting. Dispatched after the commit, or a worker could look for an invoice that has not landed yet. And copy-on-issue is not enough on its own: an invoice issued while the office connection was down never arrives, the queue eventually gives up, and nobody opens an archive to check whether last Tuesday is in it. An hourly sweep re-queues whatever is still missing, the failure is recorded on the invoice rather than only in a log, and the Finance page says how many are outstanding. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| ConfirmDeleteDatacenter.php | ||
| ConfirmDeletePlanDraft.php | ||
| ConfirmDeleteVpnPeer.php | ||
| ConfirmDisableTwoFactor.php | ||
| ConfirmEndOtherSessions.php | ||
| ConfirmForgetSecret.php | ||
| ConfirmReissueVpnPeer.php | ||
| ConfirmRemoveHost.php | ||
| ConfirmSaveEnv.php | ||
| ConfirmSaveSecret.php | ||
| Customers.php | ||
| Datacenters.php | ||
| EditDatacenter.php | ||
| EditInvoiceSeries.php | ||
| Finance.php | ||
| HostCreate.php | ||
| HostDetail.php | ||
| Hosts.php | ||
| InstanceAdminAccess.php | ||
| Instances.php | ||
| Integrations.php | ||
| Invoices.php | ||
| Mail.php | ||
| Maintenance.php | ||
| Overview.php | ||
| PlanVersions.php | ||
| Plans.php | ||
| Provisioning.php | ||
| Revenue.php | ||
| Sessions.php | ||
| Settings.php | ||
| TwoFactorSetup.php | ||
| Vpn.php | ||
| VpnConfigAccess.php | ||