2277dfe4cb
tests / pest (push) Failing after 8m24s
Details
tests / assets (push) Successful in 26s
Details
tests / release (push) Has been skipped
Details
vat_id_verified_at was declared on the customer and read by TaxTreatment, and set by no code anywhere. hasVerifiedVatId() therefore never returned true, so reverse charge could not trigger for anybody - and every EU business customer was invoiced Austrian VAT they cannot reclaim in their own country, which is not a pass-through for them but a real cost until the invoice is corrected. The check has THREE outcomes, and the third is why VatIdCheck exists. VIES is a gateway onto twenty-seven national registers and any of them is regularly down. Reading "I could not ask" as "not registered" would clear a verification that has stood for months, move that customer onto the domestic rate, and change what their next invoice says - because a register was asleep. Reading it as "registered" would put reverse charge on an unchecked number, which is our liability. So on UNAVAILABLE nothing at all is written. Asked at the moment the number is entered, because that is when somebody is looking at the field and can fix a typo. The save has already happened by then and the check cannot undo it: a register that is down must not cost a customer their address change. Shape and membership are refused before a request is spent, and the fake refuses on the same rule as the real verifier. A fake that answers where VIES would never have been asked is not a simplification but a different product, and free text normalises into a well-formed number more easily than it looks - "not a number" becomes NOTANUMBER, which the shape rule alone reads as a Norwegian one. clupilot:verify-vat-ids re-asks about the numbers reverse charge rests on, since a registration can be withdrawn. Deliberately not scheduled: it queries a public service with a concurrency limit on behalf of somebody else's tax position, and the cadence is the owner's to set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| AddonCancellationTest.php | ||
| AddonEntitlementTest.php | ||
| ApplyPlanChangeTest.php | ||
| ArchivePullAccessTest.php | ||
| CustomDomainAccessTest.php | ||
| CustomerTypeTest.php | ||
| ExportTargetFormTest.php | ||
| FinanceSettingsTest.php | ||
| GrantAddonTest.php | ||
| GrantInvoiceTest.php | ||
| GrantSubscriptionTest.php | ||
| InvoiceArchiveTest.php | ||
| InvoiceListTest.php | ||
| InvoiceMailTest.php | ||
| InvoiceMathTest.php | ||
| InvoiceNumberTest.php | ||
| IssueInvoiceTest.php | ||
| PendingPlanChangeTest.php | ||
| PlanCatalogueTest.php | ||
| PlanChangeTest.php | ||
| ProofRegisterTest.php | ||
| RenewalInvoiceTest.php | ||
| StorageAllowanceTest.php | ||
| StripeAddonBillingTest.php | ||
| StripeBillingTest.php | ||
| StripePlanChangeTest.php | ||
| VatIdVerificationTest.php | ||
| WithdrawalTest.php | ||