a84251260c
tests / pest (push) Failing after 9m6s
Details
tests / assets (push) Successful in 22s
Details
tests / release (push) Has been skipped
Details
The inbox kept saying no mailbox was set up while the password sat right
there on the settings page. isConfigured() read
config('services.inbound_mail.password'), which is only ever the .env
value: this project deliberately does not overlay stored secrets onto config
at boot — SecretVault's own docblock says so, and HttpMonitoringClient reads
its token at the point of use for exactly that reason. My docblock even
asserted the opposite mechanism, which I never verified. It reads the vault
now, and falls back to .env because SecretVault::get() already does.
And a way to find out. "Verbindung prüfen" saves the form first — testing
what is on screen while the server still holds the previous values would
report on a mailbox nobody configured — then performs the same four verbs
the real fetch performs: LOGIN, SELECT, SEARCH UNSEEN. A check that proves
something easier than the actual job is worse than none.
What it reports back is one of five fixed words, never the server's own
prose: an IMAP error carries the command it failed on, and for LOGIN that
command contains the password. Each word maps to a sentence an operator can
act on — address and port, mailbox and password, the folder.
The line saying when the mailbox was last reached is on both pages, and it
is written by the SCHEDULED run as well as by the button. Otherwise "last
checked" would mean "last time somebody pressed a button", which is the less
interesting of the two: a mailbox that stopped answering at three in the
morning is the one worth seeing, and nobody presses a button at three in the
morning. It is also shown when the answer is "never" — an empty inbox and a
mailbox that stopped answering look identical, and this line is the whole
difference.
A fetch against a mailbox that just refused the login now takes nothing in
and records the refusal, rather than reporting "nothing new" — which was
true and useless.
Also: HostStepsTest asserted the literal clupilot.com for a host name. That
was true until CLUPILOT_DNS_ZONE was set to clupilot.cloud on this
installation, and then a correct configuration failed a test. The zone is
pinned in the test now; what it is about is the shape of the name and which
address it carries.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| Capacity.php | ||
| ConfirmDeleteDatacenter.php | ||
| ConfirmDeleteIncident.php | ||
| ConfirmDeletePlanDraft.php | ||
| ConfirmDeleteVpnPeer.php | ||
| ConfirmDisableTwoFactor.php | ||
| ConfirmEndOtherSessions.php | ||
| ConfirmForgetSecret.php | ||
| ConfirmReissueVpnPeer.php | ||
| ConfirmRemoveHost.php | ||
| ConfirmRestartInstance.php | ||
| ConfirmSaveEnv.php | ||
| ConfirmSaveSecret.php | ||
| CustomerDetail.php | ||
| Customers.php | ||
| Datacenters.php | ||
| EditCustomer.php | ||
| EditDatacenter.php | ||
| EditExportTarget.php | ||
| EditInvoiceSeries.php | ||
| EditMailTemplate.php | ||
| EditPlanFamily.php | ||
| Finance.php | ||
| GrantPlan.php | ||
| HostCreate.php | ||
| HostDetail.php | ||
| Hosts.php | ||
| Inbox.php | ||
| Incidents.php | ||
| InstanceAdminAccess.php | ||
| Instances.php | ||
| Integrations.php | ||
| Invoices.php | ||
| Mail.php | ||
| MailLog.php | ||
| MailTemplates.php | ||
| Maintenance.php | ||
| NewInvoice.php | ||
| Overview.php | ||
| PlanVersions.php | ||
| Plans.php | ||
| Provisioning.php | ||
| RecordWithdrawal.php | ||
| Revenue.php | ||
| Sessions.php | ||
| Settings.php | ||
| TwoFactorSetup.php | ||
| Vpn.php | ||
| VpnConfigAccess.php | ||